Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry pruning when skaffold could not prune local images due running containers #3643

Merged
merged 4 commits into from
Feb 7, 2020
Merged

retry pruning when skaffold could not prune local images due running containers #3643

merged 4 commits into from
Feb 7, 2020

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Feb 5, 2020

Fixes #3624

@tejal29 tejal29 changed the title retry removing error when skaffold could not prune local images due running containers retry pruning when skaffold could not prune local images due running containers Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited
Loading

Codecov Report

Merging #3643 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/initializer/analyze.go 87.75% <0.00%> (-0.49%) ⬇️
pkg/skaffold/build/buildpacks/logger.go 0.00% <0.00%> (ø) ⬆️
pkg/skaffold/event/event.go 92.94% <0.00%> (+0.02%) ⬆️
pkg/skaffold/build/buildpacks/lifecycle.go 75.00% <0.00%> (+3.57%) ⬆️

balopat
balopat reviewed Feb 7, 2020
View reviewed changes
pkg/skaffold/docker/image.go Outdated
@@ -39,6 +41,11 @@ import (
"github.com/GoogleContainerTools/skaffold/pkg/skaffold/util"
)

const (
retrials = 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
retrials = 5
retries = 5

balopat
balopat approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits + please do a goimports, Travis is failing.
This is not a perfect solution but should help with some basic stuff.

For those workloads that have long terminationGracePeriodSeconds and/or don't accept SIGTERM from Kubernetes, this will still be an issue.
This issue is another motivation for implementing the --terminator in skaffold dev that would overwrite in dev mode the terminationGracePeriodSeconds to 0.

@tejal29
Copy link
Contributor Author

tejal29 commented Feb 7, 2020

LGTM with nits + please do a goimports, Travis is failing.

Thanks. Yes ./hack/linter was giving me a hard time with google installed go. I fixed it over last couple of days.

This is not a perfect solution but should help with some basic stuff.

For those workloads that have long terminationGracePeriodSeconds and/or don't accept SIGTERM from Kubernetes, this will still be an issue.
This issue is another motivation for implementing the --terminator in skaffold dev that would overwrite in dev mode the terminationGracePeriodSeconds to 0.

Agreed!

@balopat balopat merged commit 8bdeebc into GoogleContainerTools:master Feb 7, 2020
@fmotrifork fmotrifork mentioned this pull request Feb 24, 2020
Merged
@tejal29 tejal29 deleted the re-try branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Prune Image, Being Used by Running Container
3 participants
@tejal29 @balopat @googlebot